Repeat specification for repeatWhen #3593
Conversation
|
@Desislav-Petrov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@Desislav-Petrov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Desislav-Petrov Thank you for signing the Contributor License Agreement! |
| .concatMap(retryWhenState -> { | ||
| RepeatSignal copy = retryWhenState.copy(); | ||
| long iteration = copy.getRepeatsSoFar(); | ||
| if (iteration > repeats) { |
There was a problem hiding this comment.
I don't think this is the most graceful way to do this, was trying to get some inspiration from the Retry one but the case is slightly different there
Desislav-Petrov
force-pushed
the
repeat_uplift
branch
from
88acec7 to
ab0d08f
Compare
|
Hey, @Desislav-Petrov. I'm trying to go through some PRs that were not given enough attention. Please accept the team's apologies. I had a brief look and would like to know whether after not gaining much attention from us you are still willing to make progress on this. My first concern is a public API change - we need to make sure that anything that we add does not remove existing functionality. Also, the next(-1) signal looks suspicious - in case of differences between the implementation in reactor-extras, can you list them with a high-level explanation? Let me know, thanks. |
|
Hey @chemicL - I'm still keen on working on that as long as I get some support/gudaince - let me take a look since it's been a while to summarise the idea. |
|
@Desislav-Petrov take your time. I'll try to be helpful. Should I be occupied to the limits with other concerns, I'll be sure to let you know. |
|
@Desislav-Petrov it's been a month since my last message. Let's reopen if you think you'll find the time to make some progress. |
hi @chemicL and @OlegDokuka - kicked off some work for #3545 but wanted to verify the approach before i go any further.
So my plan is as follows.