Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pull Request template #3650

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Adding Pull Request template #3650

merged 3 commits into from
Nov 27, 2023

Conversation

chemicL
Copy link
Member

@chemicL chemicL commented Nov 24, 2023

With the template, contributors can learn our conventions and strategy for squash merge commit so that the PR description is properly formatted.

With the template, contributors can learn our conventions and strategy
for squash merge commit so that the PR description is properly formatted.
@chemicL chemicL added the type/chores A task not related to code (build, formatting, process, ...) label Nov 24, 2023
@chemicL chemicL added this to the 3.6.1 milestone Nov 24, 2023
@chemicL chemicL self-assigned this Nov 24, 2023
@chemicL chemicL requested a review from a team as a code owner November 24, 2023 12:13
@violetagg
Copy link
Member

@chemicL Are you targeting only Reactor Core or Project Reactor? If it is the latter you need to add this on the Project Reactor level here https://github.com/reactor/.github/tree/main/.github/ISSUE_TEMPLATE

Please validate the title has the following format:
[OPTIONAL_TAG] One line summary

OPTIONAL_TAG examples: [polish], [test], [doc] or [build].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is used in the release notes so it is not that good to have this on the title level.
Previously we agreed to have this only on commit level.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that slipped. We'll just need to remember when merging.

@chemicL
Copy link
Member Author

chemicL commented Nov 24, 2023

@chemicL Are you targeting only Reactor Core or Project Reactor? If it is the latter you need to add this on the Project Reactor level here https://github.com/reactor/.github/tree/main/.github/ISSUE_TEMPLATE

Just Reactor Core. If we find this approach useful and other projects would like to benefit from it, we can always move this template to the broader configuration.

@chemicL chemicL merged commit 12770c7 into main Nov 27, 2023
6 checks passed
@chemicL chemicL deleted the pr-template branch November 27, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants