-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pull Request template #3650
Conversation
With the template, contributors can learn our conventions and strategy for squash merge commit so that the PR description is properly formatted.
@chemicL Are you targeting only Reactor Core or Project Reactor? If it is the latter you need to add this on the Project Reactor level here https://github.com/reactor/.github/tree/main/.github/ISSUE_TEMPLATE |
.github/pull_request_template.md
Outdated
Please validate the title has the following format: | ||
[OPTIONAL_TAG] One line summary | ||
|
||
OPTIONAL_TAG examples: [polish], [test], [doc] or [build]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is used in the release notes so it is not that good to have this on the title level.
Previously we agreed to have this only on commit level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that slipped. We'll just need to remember when merging.
Just Reactor Core. If we find this approach useful and other projects would like to benefit from it, we can always move this template to the broader configuration. |
With the template, contributors can learn our conventions and strategy for squash merge commit so that the PR description is properly formatted.