Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javaagent parameter syntax #3973

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

nickcaballero
Copy link
Contributor

Fix a typo in the usage example of the reactor-tools Java agent.

@nickcaballero nickcaballero requested a review from a team as a code owner January 23, 2025 20:05
@chemicL chemicL added the type/documentation A documentation update label Jan 24, 2025
@chemicL chemicL closed this Jan 28, 2025
@chemicL chemicL reopened this Jan 28, 2025
@chemicL
Copy link
Member

chemicL commented Jan 28, 2025

Hello, thank you for your contribution. Would you please mind signing your commit (e.g. git commit -s --amend + git push origin +fix/docs/javaagent-parameter)? We recently updated our contributing guidelines to use the DCO process. Once signed, I'd be happy to accept the contribution, thanks!

@chemicL
Copy link
Member

chemicL commented Jan 31, 2025

@nickcaballero a kind reminder to sign your commit, I'd like to merge this PR, thanks!

Signed-off-by: Nick Caballero <[email protected]>
@nickcaballero nickcaballero force-pushed the fix/docs/javaagent-parameter branch from a85d773 to 2939e67 Compare January 31, 2025 18:49
@chemicL chemicL merged commit 95fe72a into reactor:main Feb 3, 2025
7 checks passed
@chemicL
Copy link
Member

chemicL commented Feb 3, 2025

Thank you, @nickcaballero :)

@chemicL chemicL added this to the 3.7.3 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants