Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using static exceptions for better debugging experience #3529

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Avoid using static exceptions for better debugging experience #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,7 +1618,7 @@ final class RequestTimeoutTask implements Runnable {
@SuppressWarnings("FutureReturnValueIgnored")
public void run() {
if (!requestAvailable) {
ctx.fireExceptionCaught(RequestTimeoutException.INSTANCE);
ctx.fireExceptionCaught(RequestTimeoutException.requestTimedOut());
//"FutureReturnValueIgnored" this is deliberate
ctx.close();
}
Expand Down
2 changes: 1 addition & 1 deletion reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServerOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ final class RequestTimeoutTask implements Runnable {
@SuppressWarnings("FutureReturnValueIgnored")
public void run() {
if (ctx.channel().isActive() && !(isInboundCancelled() || isInboundDisposed())) {
onInboundError(RequestTimeoutException.INSTANCE);
onInboundError(RequestTimeoutException.requestTimedOut());
//"FutureReturnValueIgnored" this is deliberate
ctx.close();
}
Expand Down
13 changes: 8 additions & 5 deletions reactor-netty-http/src/main/java/reactor/netty/http/server/RequestTimeoutException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2023-2024 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,17 +18,20 @@
import io.netty.channel.ChannelException;

final class RequestTimeoutException extends ChannelException {

static final RequestTimeoutException INSTANCE = new RequestTimeoutException();
static final String REQUEST_TIMED_OUT = "Request timed out";

private static final long serialVersionUID = 422626851161276356L;

RequestTimeoutException() {
super(null, null, true);
RequestTimeoutException(String message) {
super(message);
}

@Override
public synchronized Throwable fillInStackTrace() {
return this;
}

static RequestTimeoutException requestTimedOut() {
return new RequestTimeoutException(REQUEST_TIMED_OUT);
}
}