Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javascript play to the jsx extension for javascript play durin… #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Angra974
Copy link

Since some month, we have this problem trying to update the application to vite js
The play extension for javascript need to have the jsx extension.

React use the jsx extension as a standard and even if with babel and transpiler we can use the language in js file, it's not recommanded to do it.

This just give the ability to create the file with the correct extension without a problem in the react-play application.

Description

The code talk by itself. Just a file rename with the appropriate extension.

Fixes #38
Fixes #41

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using vite daily with react-play.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the create play service according to the new platform requirement
1 participant