Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC Tree Component, TocItems array on publication state #37

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bluefirepatrick
Copy link
Member

This draft PR adds a modal dialog for the TOC using the beta react-aria-components Tree control. It also creates a TocItem array -a hierarchical plain objects array with unique ids for each toc item -and stores this array on the publication state.

This book has a multi-level TOC that is useful for testing:
https://github.com/readium/go-toolkit/blob/develop/test/feedbooks_book_6816.epub

Any changes/comments are welcomed.

@JayPanoz JayPanoz mentioned this pull request Dec 3, 2024
@HadrienGardeur HadrienGardeur added this to the Core affordances milestone Dec 4, 2024
@JayPanoz
Copy link
Contributor

JayPanoz commented Dec 9, 2024

As a quick heads up, branch action-refinements will be merged into develop with most actions disabled as they’re not currently functional so that the main deployment page can benefit from other improvements + new showcase publications. And start work on theming from develop.

I tested this branch and checked the conflicts to make sure they are pretty trivial to resolve. I don’t forecast dramatic changes that will impact this draft PR so we should be able to change the target from action-refinements to develop w/o creating an issue further down the line.

I’m not forgetting I owe you an in-depth review, @bluefirepatrick 🙏

@JayPanoz JayPanoz changed the base branch from action-refinements to develop December 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants