[Chore] Dependencies upgrade #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except Vercel cos’ it still fails
chocolatkey
reviewed
Dec 19, 2024
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| v20 | |||
There was a problem hiding this comment.
@JayPanoz Why are we using an older Node version? v22 is the active LTS, v23 is the current latest.
There was a problem hiding this comment.
Ah I'm afraid that was me focusing on Cloudflare's default 18.7.x version and forgetting about the LTS release in October.
Will switch to lts/* and see if that works for it so that we don't have too keep the nvmrc updated.
There was a problem hiding this comment.
And Cloudflare doesn’t like it:
08:12:33.063 Installing nodejs lts/*
08:12:33.128 mkdir: cannot create directory '/opt/buildhome/.asdf/installs/nodejs/lts/*': No such file or directory
08:12:33.605 Trying to update node-build... ok
08:12:33.638 node-build: definition not found: 20
08:12:33.645 Error: Exit with error code: 1
08:12:33.645 at ChildProcess.<anonymous> (/snapshot/dist/run-build.js)
08:12:33.646 at Object.onceWrapper (node:events:652:26)
08:12:33.646 at ChildProcess.emit (node:events:537:28)
08:12:33.646 at ChildProcess._handle.onexit (node:internal/child_process:291:12)
08:12:33.656 Failed: build command exited with code: 1
08:12:34.347 Failed: error occurred while running build command
Note: It seems to resolve to 22.8 when setting v22
Deploying playground with
|
| Latest commit: |
1eabf42
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3aaa2501.playground-7xz.pages.dev |
| Branch Preview URL: | https://deps-upgrade.playground-7xz.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade dependencies to their latest version (NextJS 15, React 19, etc.). It also leverages this opportunity to remove unused dependencies.
Note CF deploy is still impacted by the issue listed in #34 so Vercel is being kept to get around this issue.
The project should be buildable and deployable (deps-upgrade.playground-7xz.pages.dev), and should not create new issues.
I’ll request a review though, given there are major version bumps, in the hope we can confirm everything is fine for every consumer of the project.