Windows RT work #124
Open
Windows RT work #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these changes fixed linking issues.
* zip_fread will always terminate after 5,001 deflate loops (if the deflate all returned Z_OK or Z_STREAM_END) * debug messages everywhere * following lines added to zip_fread.c for debug functionality (should only work when compiling for 32-bit): #define _X86_ #include <debugapi.h>
…erty from root element of OPF document
…c property of SMIL element (we fail to get the property if we provide a namespace).
…ce, if the attribute is not found look for the attribute without the namespace.
|
Note that UTF-8 BOM handling was added in the ReadiumSDK, but it only works with libxml (not in the case of #if EPUB_USE(WIN_XML)). See manifest.cpp, and io.h/cpp |
|
Note that there is an ongoing effort to remove unused async-bytestream code, please check the feature branch diff: |
|
Note that this may be moot if we decide to abandon the desktop applications in favor of a Chrome or Cordova-based solution. So we need to decide that first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now compiles in Visual Studio 2013 and Windows 8.1
Some issues such as UTF-8 BOM breaking the XML parser and the Windows XML parser strictly applying rules to attribute namespaces have been (somewhat) addressed. We added a hack to libzip's zip_fread to break it out of the read loop because sometimes it wouldn't end. (We didn't track down the root cause of this issue.)
The VSIX installer also works.