Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in pagination event handler when raised with no spine item #407

Open
wisfan opened this issue Sep 14, 2017 · 2 comments
Open

Errors in pagination event handler when raised with no spine item #407

wisfan opened this issue Sep 14, 2017 · 2 comments

Comments

@wisfan
Copy link
Contributor

wisfan commented Sep 14, 2017

This issue is a Bug

Related issue(s) and/or pull request(s)

PR #409

Observed behaviour

Errors from pagination change handler when ExternalAgentSupport.updateContentDocument invoked with no spineItem.

Steps to reproduce

Easiest way to reproduce: use ScrollView, scroll through a spine item and observe the JS console.

ScrollView and ReflowableView both emit pagination events without setting spineItem and elementId in the event data. This causes errors when the data is passed through to ExternalAgentSupport.

Product

Only users of current develop branch, does not affect master

@danielweck
Copy link
Member

Fixed reflow view: 6d8beaa#diff-5899c9a9fc900e9651da6e2d81f3025b

@danielweck
Copy link
Member

TODO / TO-CHECK:

onPaginationChanged(self);

onPaginationChanged(self);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants