Skip externalAgentSupport call when spineItem not available #409
Conversation
… spineItem value.
|
Thank you! @jccr and I had a look, but need to figure out a "proper" fix so that further occurrences of this bug can be prevented in other places in the code. |
| @@ -280,6 +280,8 @@ var ReaderView = function (options) { | |||
| _.defer(function () { | |||
| Globals.logEvent("PAGINATION_CHANGED", "EMIT", "reader_view.js"); | |||
| self.emit(Globals.Events.PAGINATION_CHANGED, pageChangeData); | |||
|
|
|||
| if (!pageChangeData.spineItem) return; | |||
| _.defer(function () { | |||
There was a problem hiding this comment.
pageChangeData.spineItem is also used in the Media Overlays player, via the line above (_mediaOverlayPlayer.onPageChanged(pageChangeData);). Thankfully, there are safeguards inside the MO code, so no crashes. Unfortunately, we use var spineItems = reader.getLoadedSpineItems(); to match pageChangeData.spineItem in multiple page spreads (fixed layout), so it would be nice if the spineItem property was set correctly in all view types (inc. reflow and scroll).
There was a problem hiding this comment.
Note that I fixed the reflow view: 6d8beaa
|
Merged this as reasonable safety guard for nil spineItem. |
|
Great, thanks, Daniel! |
This pull request is a Work In Progress
Related issue(s) and/or pull request(s)
Issue #407
Alternately, ensure that spineItem is always populated?
ReflowableView:863
ScrollView:281
ScrollView:554
FixedView:200