User advertiser member check and constraint #1093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit this extremely minor bug in production. If you try to add the same user again as an authorized user on an advertiser, you hit a DB constraint (500 error). That's because the constraint added here exists in production but not in the model. That is because at first the UserAdvertiserMember model was just an automatic table and then we added a new column to the table via migration. This adds a secondary check to ensure we don't try to add the same user again and adds the constraint in development. Hopefully there isn't an issue adding that constraint again in prod or we could fake the migration if desired since the constraint already exists.
ericholscher
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this extremely minor bug in production. If you try to add the same user again as an authorized user on an advertiser, you hit a DB constraint (500 error).
That's because the constraint added here exists
in production but not in the model. That is because at first the UserAdvertiserMember model was just an automatic table and then we added a new column to the table via migration.
This adds a secondary check to ensure we don't try to add the same user again and adds the constraint in development. Hopefully there isn't an issue adding that constraint again in prod or we could fake the migration if desired since the constraint already exists.