Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: all packages updated via pip-tools #11625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Dependencies: all packages updated via pip-tools

@github-actions github-actions bot requested a review from a team as a code owner September 29, 2024 00:08
@humitos
Copy link
Member

humitos commented Sep 30, 2024

It seems that only the flaky tests are failing.

@@ -121,7 +121,7 @@ django==4.2.16
# django-timezone-field
# djangorestframework
# jsonfield
django-allauth[mfa,saml,socialaccount]==64.2.1
django-allauth[mfa,saml,socialaccount]==65.0.2
Copy link
Member

@humitos humitos Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important changes:

When the user is partially logged in (e.g. pending 2FA, or login by code), accessing the login/signup page now redirects to the pending login stage. This is similar to the redirect that was already in place when the user was fully authenticated while accessing the login/signup page. As a result, cancelling (logging out of) the pending stage requires an actual logout POST instead of merely linking back to e.g. the login page. The builtin templates handle this change transparently, but if you copied any of the templates involving the login stages you will have to adjust the cancel link into a logout POST.

(https://docs.allauth.org/en/latest/release-notes/recent.html#id2)

cc @agjohnson since you worked on the templates.
cc @stsewd since you implemented 2FA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like templates may need to be updated. Here is the PR https://codeberg.org/allauth/django-allauth/pulls/4111/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants