Unresolver: allow a full URL when un-resolving a domain #11632
Conversation
This also checks that the URL has a valid protocol.
stsewd
force-pushed
the
check-uri-protocol
branch
from
bbe0343
to
0638e30
Compare
There was a problem hiding this comment.
I left some questions about this PR.
I'm a little confused with the names here. We call this method unresolve_domain, but it could also receive a URL now. However, we have another method called unresolve_url. Shouldn't we standardize this and call unresolve_domain or unresolve_url depending on what the input we have?
With this changes, what is the difference between unresolve_url and unresolve_domain now?
| with pytest.raises(InvalidSubdomainError): | ||
| unresolve("https:///pip.readthedocs.io/en/latest/") |
There was a problem hiding this comment.
Why this raises InvalidSubdomainError?
There was a problem hiding this comment.
A tripe /// is interpreted as a URL without a domain.
unresolve_domain will resolve the domain only, everything else is ignored (it's in the docstring). |
This also checks that the URL has a valid protocol. This is needed for https://github.com/readthedocs/readthedocs-corporate/pull/1887.