Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Business docs #11635

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Business docs #11635

wants to merge 3 commits into from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 1, 2024

The main update here is a set of common approaches to customer sharing,
and made the Privacy Levels doc make more sense.

I also went through and patched up a few other pages.

Fixes https://github.com/readthedocs/readthedocs-corporate/issues/1871


📚 Documentation previews 📚

The main update here is a set of common approaches to customer sharing,
and made the Privacy Levels doc make more sense.

I also went through and patched up a few other pages
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments that I found.

docs/user/commercial/organizations.rst Show resolved Hide resolved
.. seealso::

:doc:`/guides/manage-read-the-docs-teams`
A step-by-step guide to managing teams.

Member types
~~~~~~~~~~~~
Important concepts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call this "Important concepts", since it doesn't not reflects what this section is about. I think "Member types" was a better name and communicated this better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Teams" is not a member type, tho. So, maybe, "Auth concepts" could work better here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, the Teams bit was the odd part I was trying to work around.

docs/user/commercial/organizations.rst Outdated Show resolved Hide resolved
docs/user/commercial/organizations.rst Outdated Show resolved Hide resolved
docs/user/commercial/privacy-level.rst Outdated Show resolved Hide resolved
docs/user/commercial/sharing.rst Outdated Show resolved Hide resolved
docs/user/commercial/sharing.rst Outdated Show resolved Hide resolved
docs/user/commercial/sharing.rst Outdated Show resolved Hide resolved
This is useful to have access from a script.

Enabling sharing
Creating a share
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creating a share
Creating a sharing item

docs/user/commercial/sharing.rst Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member Author

Updated to address all the feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants