Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: disable search filters for now #11638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 2, 2024

I'm disabling search filters until we implement the Admin UI page to customize them.

It requires readthedocs/addons#391

I'm disabling search filters until we implement the Admin UI page to customize
them.

It requires readthedocs/addons#391
@humitos humitos requested a review from a team as a code owner October 2, 2024 13:47
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a reasonable default is to check if the project has any subprojects and include the filter. I'm fine with this for now though, since if it's not configurable, we should probably hide it until it is.

@humitos
Copy link
Member Author

humitos commented Oct 2, 2024

Cool! Yeah, I prefer to show nothing for now that something it's fixed and can't be disabled for now. I'm happy to change that behavior in the near future, but let's start simple for now 😄

We have readthedocs/addons#22 opened to track the customization of these filters, and also readthedocs/addons#289 to make these filters checked by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants