File tree diff #11646
Draft
File tree diff #11646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Oct 3, 2024
readthedocs/search/parsers.py
Outdated
Comment on lines
23
to
24
| @functools.cache | ||
| def _get_page_content(self, page): |
There was a problem hiding this comment.
I'm afraid this may implode our memory usage :D, some options:
- Just read the content from storage twice.
- When parsing the content (search indexing), we can calculate the hash of the main content, and save that for later, so we will be saving just the hash, and not the whole content. This will make things faster, but it mixes things...
There was a problem hiding this comment.
Went with the second idea in ed5377d
stsewd
commented
Oct 3, 2024
Comment on lines
+65
to
+70
| build_id_from_manifest = manifest.get("build", {}).get("id") | ||
| if latest_successful_build.id != build_id_from_manifest: | ||
| # The manifest is outdated, | ||
| # do we want to still use it? do we care? | ||
| # Should the caller be responsible to handle this? | ||
| return None |
There was a problem hiding this comment.
I guess this may depend on how do we want to expose this feature on the addons. I guess maybe the caller or the addons client should be responsible for deciding what to do here, maybe show the ft diff, but with a warning.
|
This is still missing tests and docstrings, but it would be great to have a review if we are good with this direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #11643.
Closes #11319
Ref #11507