Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version sync: restore verbose_name for stable version #11941

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 22, 2025

Closes #11939

This also discovered another problem, we are using the verbose name to check for latest/stable, but we should use the slug

if self.version_machine and self.verbose_name == STABLE_VERBOSE_NAME:
if self.version_identifier:
return f"{self.version_identifier}"
log.error("'stable' version without a commit hash.")
return None
tag_name = self.verbose_name
# For a machine created "latest" tag, the name of the tag is set
# in the `Version.identifier` field, note that it isn't a commit
# hash, but the name of the tag.
if self.version_machine and self.verbose_name == LATEST_VERBOSE_NAME:

Will try to fix that in another PR, as we need to pass the slug down...

@stsewd stsewd requested a review from a team as a code owner January 22, 2025 19:40
@stsewd stsewd requested a review from humitos January 22, 2025 19:40
@humitos
Copy link
Member

humitos commented Jan 27, 2025

This also discovered another problem, we are using the verbose name to check for latest/stable, but we should use the slug

We should add a TODO comment on that file that you linked so we know there is a problem there.

@stsewd
Copy link
Member Author

stsewd commented Jan 27, 2025

#11955

@stsewd stsewd merged commit e5c3714 into main Jan 27, 2025
8 checks passed
@stsewd stsewd deleted the restore-verbose-name-for-stable branch January 27, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stable version tries to pull Stable tag causing build failure
2 participants