Transactions aren't executed with "psql -c" #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlbnks
approved these changes
Aug 31, 2023
tokio-postgres/tests/test/main.rs
Outdated
| } | ||
| } | ||
|
|
||
| match client |
There was a problem hiding this comment.
Probably can just be client.simple_query(..).await.unwrap()
tokio-postgres/tests/test/main.rs
Outdated
| _ => panic!("unexpected message"), | ||
| } | ||
| match &messages[3] { | ||
| SimpleQueryMessage::CommandComplete(CommandCompleteContents { fields: f, .. }) => { |
There was a problem hiding this comment.
This can be SimpleQueryMessage::CommandComplete(CommandCompleteContents { fields, .. }) if fields.is_none() => {}. Then the fields.is_some() case is captured in _ =>. Same for the below cases.
Also this is a nit, but we typically wouldn't alias using fields: f, instead of referencing as fields,
tokio-postgres/tests/test/main.rs
Outdated
| } | ||
| match &messages[4] { | ||
| SimpleQueryMessage::CommandComplete(CommandCompleteContents { fields: f, .. }) => { | ||
| if let Some(field_vec) = &f { |
There was a problem hiding this comment.
I think you can match with SimpleQueryMessage::CommandComplete(CommandCompleteContests { fields: Some(f), ... }) instead of checking whether fields is_some() in the body.
The transaction did not appear to execute when running a set of SQL commands using psql commands with the '-c' option, such as "SELECT * FROM t; BEGIN; UPDATE t SET k = id; END;". This issue was caused by the tokio-postgres crate adding column information to all EmptyQueryResponses for every SQL query. The resolution for this issue was to only add the column information to 'SELECT' queries.
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this pull request
Sep 1, 2023
Bump deps on crates in our rust-postgres fork to include this merged PR: readysettech/rust-postgres#9 Change-Id: I59d1f7882b74d6c418eea8eef35ada1c26c4f7f7
readysetbot
pushed a commit
to readysettech/readyset
that referenced
this pull request
Sep 2, 2023
Bump deps on crates in our rust-postgres fork to include this merged PR: readysettech/rust-postgres#9 Change-Id: I59d1f7882b74d6c418eea8eef35ada1c26c4f7f7 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/5958 Tested-by: Buildkite CI Reviewed-by: Dan Wilbanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction did not appear to execute when running a set of SQL commands using psql commands with the '-c' option, such as "SELECT * FROM t; BEGIN; UPDATE t SET k = id; END;". This issue was caused by the tokio-postgres crate adding column information to all EmptyQueryResponses for every SQL query. The resolution for this issue was to only add the column information to 'SELECT' queries.