Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!chore: write upgrade handler for new minimum commission rate #157

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

neitdung
Copy link
Collaborator

@neitdung neitdung commented Jun 17, 2024

closes #151

reopen #152


Description:

  • Change staking params' min commission rate to 5%
  • Update all validators commission rate

@neitdung neitdung requested a review from jiujiteiro as a code owner June 17, 2024 03:58
@neitdung neitdung requested a review from catShaark June 17, 2024 04:00
Copy link
Collaborator

@jiujiteiro jiujiteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a changelog entry?

app/upgrades/commission/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/commission/upgrades.go Outdated Show resolved Hide resolved
@neitdung
Copy link
Collaborator Author

neitdung commented Jun 19, 2024

Hi @jiujiteiro, I've added the changelog and updated code by your review. Please let me know if we need anything else.

Copy link
Collaborator

@jiujiteiro jiujiteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. everything else looks good

CHANGELOG.md Outdated Show resolved Hide resolved
@jiujiteiro jiujiteiro merged commit c1454d9 into realiotech:main Jun 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Upgrade handler to modify commission %
2 participants