Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pose unlock smooths in wrong coordinate space #145

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Jul 25, 2024

Reality Collective - Reality Toolkit Pull Request

Overview

  • Turns out the source pose reported to the IControllerPoseSynchronizer is in the rigs local space and not world space. This caused issues when smoothing the visualizer pose from the interactable lock pose to the actual controller pose when the player rig is not located at the scene origin. Also I realized we do not need an extra IControllerVisualizer.SourcePose property that was recently introduced, since we can simply use IControllerVisualizer.Controller.Pose for that

  • Introduced IInputRig. Same concept as with the locomotion service. The input service expects an IInputRig to be available in the scene so the input service components, such as controllers, can work. The toolkit's player package is a first party citizen and comes with an out of the box input rig, which is the player rig itself. If, for whatever reason, someone decides to use the input service without the player package, then they have to make sure to register the IInputRig manually using their own implementation. This is a very advanced use case scenario though. For testing I have already replaced some of the Camera.main references in the core module using the new InputService.InputRig API. I'll do another PR updating the rest. Resolves RFI: The Input System is unable to operate without a specific camera setup, currently managed by a dependency? #77

@FejZa FejZa merged commit 879f0c5 into development Jul 25, 2024
9 checks passed
@FejZa FejZa deleted the feature/fix-pose-unlock branch July 25, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFI: The Input System is unable to operate without a specific camera setup, currently managed by a dependency?
1 participant