Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Unicode: Materials #433

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Sort Unicode: Materials #433

merged 6 commits into from
Sep 22, 2023

Conversation

bzaczynski
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@acsany acsany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also providing the HTML file. That's the perfect fallback in case installing PyICU doesn't work.

As optional improvements, you may consider:

  • Adding a note to the Readme about the problems of installing PyICU (similar to your paragraph in the tutorial)
  • Providing two requirement files and Jupyter notebooks the materials. One that contains the PyICU parts, and one that doesn't. But personally, I think the HTML file is a good solution for any installation issues.

@bzaczynski
Copy link
Contributor Author

@acsany Okay, I've added a side note about the potential hurdles with installing PyICU and where to find more help.

@KateFinegan KateFinegan merged commit 0e7f7a4 into master Sep 22, 2023
1 check passed
@KateFinegan KateFinegan deleted the python-sort-unicode-strings branch September 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants