Rich showcase #458
Merged
Rich showcase #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source files and Jupyter notebook for the Rich showcase article.
acsany
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Hi @profcalculus,
thanks for providing the materials. I left you a few comments below.
Also, I was wondering if we really need the Jupyter notebook as a "replica" of the tutorial. But I leave this up to you 🙂
rich_showcase/README.md
Outdated
| ```console | ||
| (venv) $ python -m pip install requests | ||
| ``` | ||
| The code to perform the download is in get_rich_showcase_data.py. This demo code demonstrates a single request, which it then dumps to the screen; for a real-time application you would need to execute this request and process the data in a loop. The [CoinLore website](https://www.coinlore.com/cryptocurrency-data-api) doesn't impose rate limits, but they suggest making one request per second. |
There was a problem hiding this comment.
Suggested change
| The code to perform the download is in get_rich_showcase_data.py. This demo code demonstrates a single request, which it then dumps to the screen; for a real-time application you would need to execute this request and process the data in a loop. The [CoinLore website](https://www.coinlore.com/cryptocurrency-data-api) doesn't impose rate limits, but they suggest making one request per second. | |
| The code to perform the download is in `get_rich_showcase_data.py`. This demo code demonstrates a single request, which it then dumps to the screen; for a real-time application you would need to execute this request and process the data in a loop. The [CoinLore website](https://www.coinlore.com/cryptocurrency-data-api) doesn't impose rate limits, but they suggest making one request per second. |
rich_showcase/dynamic_status.py
Outdated
Comment on lines
11
to
13
| time.sleep(10) | ||
| for _ in range(10): | ||
| print() |
There was a problem hiding this comment.
Is this needed?
Suggested change
| time.sleep(10) | |
| for _ in range(10): | |
| print() |
rich_showcase/rich_showcase_table.py
Outdated
| from rich.table import Table | ||
| from rich.live import Live | ||
| from rich.console import Console | ||
| from rich_showcase_data import DEMO_DATA |
There was a problem hiding this comment.
To make it more clear, you could consider changing rich_showcase_data.py into a JSON file and import this one into a DEMO_DATA dictionary.
Co-authored-by: Philipp Acsany <[email protected]>
Co-authored-by: Philipp Acsany <[email protected]>
|
Hi @acsany , I removed the .ipynb file and revised the table to read a JSON file as you suggested. Should be ready to go now?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: