Portable toplevel exit #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, you just got:
ocaml-mdx-test: internal error, uncaught exception:
Compenv.Exit_with_status(125)
They have to be redirected because by default they write to stdout, but we capture stderr (and in 4.14 they write to stderr). Unfortunately, just overwriting them in the directives Hashtbl does not work, since the ordering of additions is somewhat undefined so they might be overwritten. A safer way is to create new directives and rewrite those to be evaluated to them. Also, `"use"` is a builtin directive, not from findlib so needs to be excluded to get the error message printed.
`use_output` was added in 4.11, whereas the `use_trace` was removed in 4.13.
The stdlib pre-4.14 defines them to be `ignore`d but they can be made to throw the error like in 4.14. At least some of them, for which the underlying functions are exposed in the interface.
OCaml 4.13 introduces a few deprecations that we need to work around.
|
Pushed the changes to #382 so this can be safely closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimentation with the #382 PR opened to get the CI to test my changes on multiple versions.