ci(helm): configure target branch name for helm linting #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana
that referenced
this pull request
Jan 20, 2025
Alputer
force-pushed
the
ci-helm-lint-fix
branch
from
7726e24 to
1c6db61
Compare
Alputer
changed the title
tiborsimko
reviewed
Jan 20, 2025
| @@ -2,3 +2,4 @@ validate-maintainers: false | |||
| check-version-increment: false | |||
| chart-dirs: | |||
| - helm | |||
| target-branch: master | |||
There was a problem hiding this comment.
todo: A suggested to make the commit message headline a bit more explicit, for example: ci(helm): configure target branch name for helm linting (#863).
Alputer
force-pushed
the
ci-helm-lint-fix
branch
from
1c6db61 to
e2b6037
Compare
Alputer
changed the title
tiborsimko
approved these changes
Jan 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 31.07% 31.07%
=======================================
Files 26 26
Lines 2491 2491
=======================================
Hits 774 774
Misses 1717 1717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current helm linting github action looks for
mainbranch. However, we are usingmasterbranch. We should explicitly specifyhelmintarget-branchfield.