merge reason-parser into main source code #1330
Conversation
| @@ -93,8 +92,6 @@ You can then run: | |||
| -I "$reasonTargetDir" \ | |||
| -I "$reasonTargetDir/_build/src" \ | |||
| -I "$reasonTargetDir/vendor/cmdliner" \ | |||
| -I "$reasonParserTargetDir/_build/src" \ | |||
| -I "$reasonParserTargetDir/vendor/easy_format" \ | |||
There was a problem hiding this comment.
This needs to be added back as "$reasonTargetDir/vendor/easy_format", otherwise it's not included.
scripts/release-check.sh
Outdated
| @@ -21,8 +21,7 @@ if [ "${MASTER}" != "${HEAD}" ]; then | |||
| the release. **" | |||
| fi | |||
|
|
|||
| read -p "STOP! Have you made sure to release the sub packages (including \ | |||
| reason-parser)? (y/n) " yn | |||
| read -p "STOP! Have you made sure to release the sub packages? (y/n) " yn | |||
There was a problem hiding this comment.
Yeah I think it's fine to remove it
|
I can't repro that menhirlib error in the CI. After fixing that |
|
I tried to fix stuff, but it is still failing and I just can't see the message (seems the CI is temporarily broken too :P). |
|
Ok that's weird. Can you fix the merge conflict and push once and see if the CI retriggers and succeed? |
|
Well, at least it's a new error now |
|
I suspect the bug is just the regression with latest utop (which hides some modules, see ocaml-community/utop#213 ). |
|
Two bugs: the regression + wrong linking rules. |
|
Btw we're thinking of pulling out rtop into its own thing. Would that help here? |
|
@let-def any blockers remaining? Eager to get this in! |
|
No I would like to get this in, I am trying to understand what is failing. |
|
Seems I just forgot to add a file to the repo, hopefully rebuild works this time! |
|
Alright, I've patched it with some last fixes for bspack (which we should really automate and put on CI soon) and verified locally that the bspacking workflow works. Guess we're ready for merging? =D |
|
Fine for me :). |
|
Thanks so much =) cc @IwanKaramazow happy now? =P |
As requested in issue #1328.
I kept https://github.com/facebook/reason/compare/master...let-def:collapse-reason-parser?expand=1#diff-8d847b939af98498df86c09cf017a952L24 check but I don't think there is any other subpackage, maybe the check can be removed too.