Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce extension bug when nested inside a module #2723

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

anmonteiro
Copy link
Member

No description provided.

@anmonteiro
Copy link
Member Author

Pushed a fix for this but I'm not happy with the extra ~indent argument.

cc @jchavarri

Copy link
Contributor

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@anmonteiro anmonteiro merged commit f92f7ec into master Sep 20, 2023
24 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/repro-extension-bug branch September 20, 2023 04:31
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Feb 25, 2024
CHANGES:

- Print structure items extension nodes correctly inside modules (@anmonteiro,
  [reasonml/reason#2723](reasonml/reason#2723))
- Print wrapped type constraint on record patterns (@anmonteiro,
  [reasonml/reason#2725](reasonml/reason#2725))
- Support OCaml 5.2 (@anmonteiro, [reasonml/reason#2734](reasonml/reason#2734))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants