fix: print module expr attributes #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/fix-module-expr-attrs
branch
from
eb8db03
to
17aa6e3
Compare
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Oct 21, 2024
CHANGES: - Support `module%ppx` syntax (@anmonteiro, [reasonml/reason#2771](reasonml/reason#2771)) - Extend open to arbitrary module expression (@anmonteiro, [reasonml/reason#2773](reasonml/reason#2773)) - Wrap `let lazy patterns = ..` in parentheses (`let lazy(patterns) = ..`) (@anmonteiro, [reasonml/reason#2774](reasonml/reason#2774)) - Print poly variants as normal variansts (@sander Spies, [reasonml/reason#2708](reasonml/reason#2708)) - Improve printing of anonymous function return type (@sander Spies, [reasonml/reason#2686](reasonml/reason#2686)) - Improve printing of destructuring with local open (@sander Spies, [reasonml/reason#2684](reasonml/reason#2684)). - Parse and print attributes in binding `let` ops (@anmonteiro, [reasonml/reason#2777](reasonml/reason#2777)). - Parse polymorphic variants starting with `[|` (@anmonteiro, [reasonml/reason#2781](reasonml/reason#2781)) - Always add a line break in records with 2 or more fields (@anmonteiro, [reasonml/reason#2779](reasonml/reason#2779)) - Always break nonempty doc comments after `*/` (@anmonteiro, [reasonml/reason#2780](reasonml/reason#2780)) - Improve printing of arrows with labelled arguments (@anmonteiro, [reasonml/reason#2778](reasonml/reason#2778)) - Parse and print extensions in `open%foo` expressions and structure items (@anmonteiro, [reasonml/reason#2784](reasonml/reason#2784)) - Add support for module type substitutions (@anmonteiro, [reasonml/reason#2785](reasonml/reason#2785)) - Support `type%foo` extension sugar syntax (@anmonteiro, [reasonml/reason#2790](reasonml/reason#2790)) - Support quoted extensions (@anmonteiro, [reasonml/reason#2794](reasonml/reason#2794)) - Parse universal type variables in signature items (@anmonteiro, [reasonml/reason#2797](reasonml/reason#2797)) - Fix formatting of callbacks with sequence expressions (@anmonteiro, [reasonml/reason#2799](reasonml/reason#2799)) - Fix printing of attributes on module expressions (@anmonteiro, [reasonml/reason#2803](reasonml/reason#2803))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2802