Companion mode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reachat-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
steppy452
force-pushed
the
syang/companion
branch
from
58ac51f to
560be54
Compare
amcdnl
reviewed
Jul 31, 2024
| "reakeys": "^2.0.3", | ||
| "remark-gfm": "^4.0.0", | ||
| "remark-youtube": "^1.3.2" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
Good catch but i think we need to keep these listed as devDepedendecies too
amcdnl
reviewed
Jul 31, 2024
src/Chat.tsx
Outdated
| @@ -97,6 +99,11 @@ export const Chat: FC<ChatProps> = ({ | |||
| const [internalActiveSessionID, setInternalActiveSessionID] = useState< | |||
| string | undefined | |||
| >(activeSessionId); | |||
| const [ref, { width }] = useMeasure(); | |||
There was a problem hiding this comment.
We should use the same measure lib we use in reaviz for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Screen.Recording.2024-07-30.at.7.12.33.PM.mov
Does this PR introduce a breaking change?
Other information