-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tk/issue14 #41
Tk/issue14 #41
Conversation
✅ Deploy Preview for reachat-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@amcdnl and @steppy452 |
@flex2016 thanks for taking the time and working on this! This is a great start - it seems like there's a good base for the styling of the component. One thing we might need to align on is the requirements for the follow up message. The idea is that the follow up responses are like "quick reply" prompts for the user to choose from. So, in your example, possible follow up prompts could be "What are some downsides of React?" and "What are alternative options to React?" and if the user clicks on one of those options, it would continue the conversation as if the user typed it in. |
response={conversation.response} | ||
isLoading={isLast && isLoading} | ||
/> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here instead of an either or here, we would always show the <MessageResponse />
and optionally show <FollowUpResponse />
if some exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steppy452 Thank you for clarifying the requirements. Please review the changes I have made. Also, regarding the image, what are we expecting the image payload to be? Currently, I have it as a URL.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #14
What is the new behavior?
Does this PR introduce a breaking change?
Other information