Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tk/issue14 #41

Closed
wants to merge 4 commits into from
Closed

Tk/issue14 #41

wants to merge 4 commits into from

Conversation

flex2016
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #14

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for reachat-storybook ready!

Name Link
🔨 Latest commit 218f882
🔍 Latest deploy log https://app.netlify.com/sites/reachat-storybook/deploys/66cdd274d6a4af0008a17cdc
😎 Deploy Preview https://deploy-preview-41--reachat-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flex2016
Copy link
Author

@amcdnl and @steppy452

@steppy452
Copy link
Contributor

@flex2016 thanks for taking the time and working on this! This is a great start - it seems like there's a good base for the styling of the component. One thing we might need to align on is the requirements for the follow up message.

The idea is that the follow up responses are like "quick reply" prompts for the user to choose from. So, in your example, possible follow up prompts could be "What are some downsides of React?" and "What are alternative options to React?" and if the user clicks on one of those options, it would continue the conversation as if the user typed it in.

response={conversation.response}
isLoading={isLast && isLoading}
/>
)}
Copy link
Contributor

@steppy452 steppy452 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here instead of an either or here, we would always show the <MessageResponse /> and optionally show <FollowUpResponse /> if some exist

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steppy452 Thank you for clarifying the requirements. Please review the changes I have made. Also, regarding the image, what are we expecting the image payload to be? Currently, I have it as a URL.

@steppy452 steppy452 closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants