Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

[Feature] Be able to select option with Return key #5

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

faizanu94
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3

What is the new behavior?

Now user will be able to select option with return key

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

const newSelection = result[index]?.value || {
value: inputValue,
children: inputValue
const newSelection = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - this was it? Was it just passing the wrong var?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I verified through storybook :)

@amcdnl amcdnl merged commit e599a1b into reaviz:master Jul 18, 2022
@amcdnl
Copy link
Member

amcdnl commented Jul 18, 2022

released!

@amcdnl
Copy link
Member

amcdnl commented Jul 26, 2022

@faizanu94 I think this caused a regression with tagging.

@faizanu94
Copy link
Author

@amcdnl yeah I just saw a fix you merged with createable flag used

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants