Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen phpstan/larastan constraints #1119

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Loosen phpstan/larastan constraints #1119

merged 1 commit into from
Feb 18, 2024

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Feb 18, 2024

Summary

assertIsArray has been removed because, as phpstan rightly complained, it's not possible otherwise: the return type of formatError is always an error


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

`assertIsArray` has been removed because, as phpstan rightly complained, it's not possible otherwise: the return type of `formatError` is always an error
@mfn mfn self-assigned this Feb 18, 2024
@mfn mfn merged commit 89f3b7f into master Feb 18, 2024
58 checks passed
@mfn mfn deleted the mfn-phpstan branch February 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant