Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #931

Closed
wants to merge 3 commits into from
Closed

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Jul 14, 2022

Summary

This adds the tests for validation inside an array #930


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn
Copy link
Collaborator

mfn commented Sep 5, 2022

@leonardocustodio sorry for the long delay, can you update the PR with master please?

@leonardocustodio
Copy link
Contributor Author

There you go, I've rebased with the new changes of master

@mfn
Copy link
Collaborator

mfn commented Jan 6, 2023

@leonardocustodio sorry again for the long delay. they still where not green (you can check them yourself after you push), unfortunately the logs already have expired.

I tried a quick fix in #963 after merging master, but the errors I saw on GHA and locally were not the same so I stopped.

Can you please make the tests green?

@mfn
Copy link
Collaborator

mfn commented Mar 5, 2023

Closing due to lack of feedback

@mfn mfn closed this Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants