Skip to content

Commit

Permalink
Another attempt at fixing the disclaimer issues
Browse files Browse the repository at this point in the history
  • Loading branch information
rebkwok committed Jan 1, 2024
1 parent a14a389 commit 696c787
Showing 1 changed file with 7 additions and 15 deletions.
22 changes: 7 additions & 15 deletions accounts/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,25 +164,17 @@ def form_valid(self, form):
form = DisclaimerForm(form.data, user=self.request.user)
return render(self.request, self.template_name, {'form':form})

if self.request.user.check_password(password):
disclaimer.user = self.request.user
try:
disclaimer.save()
except ValidationError as error:
if "Active disclaimer already exists" in str(error):
messages.info(self.request, f"You already have a completed disclaimer")
cache.set(active_disclaimer_cache_key(disclaimer.user), True, timeout=600)
return HttpResponseRedirect(reverse("profile:profile"))
raise
else:
if not self.request.user.check_password(password):
form = DisclaimerForm(form.data, user=self.request.user)
return render(self.request, self.template_name, {'form':form, 'password_error': 'Password is incorrect'})

return super(DisclaimerCreateView, self).form_valid(form)
disclaimer.user = self.request.user
disclaimer.save()
return HttpResponseRedirect(self.get_success_url())

def get_success_url(self):
return reverse('profile:profile')


class NonRegisteredDisclaimerCreateView(CreateView):

form_class = NonRegisteredDisclaimerForm
Expand All @@ -206,8 +198,8 @@ def form_valid(self, form):
html_message=get_template(
'account/email/nonregistered_disclaimer_received.html').render(ctx),
fail_silently=False)

return super().form_valid(form)
disclaimer.save()
return HttpResponseRedirect(self.get_success_url())

def get_success_url(self):
return reverse('nonregistered_disclaimer_submitted')
Expand Down

0 comments on commit 696c787

Please sign in to comment.