[SYCL][Graph] Implement Graph and node queries #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement graph and node queries from spec - New node_type enum - Note, subgraph node type not yet implemented due to significant changes required - Explicit nodes now also have associated events (fixes mixed usage issue) - New tests for queries - Update linux ABI symbols
Bensuo
added
Graph Specification
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
mfrancepillois
approved these changes
Dec 21, 2023
EwanC
reviewed
Jan 3, 2024
julianmi
approved these changes
Jan 5, 2024
EwanC
approved these changes
Jan 8, 2024
Commit b32db9a added some new suggested text to the extension specification template, which was formatted as a quote. This formatting is inconsistent with the other suggested text, which is not formatted as a quote. Fix this.
…#12332) This small addition signposts interested users to instructions on adding DPC++ extensions. It was motivated by intel#12251 (comment) When looking into the logic of the docs, I found there was no signposting from the initial repo readme to tell contributors how to propose their own extensions. There have been some important third-party contributions to dpc++ and in the future it is possible such contributions could include proposing new oneapi extensions. Signed-off-by: JackAKirk <[email protected]>
…ntel#12351) This change explicitly defines multi_ptr inside the kernel instead of outside the kernel. Before, we rely on the runtime to correctly treat the lambda capture clause and create correct private copies for each of these variables. With this change, we are making sure that these variables are correctly captured (private copies) inside the kernel.
…ies of the plugins (intel#12336) Currently the default search order is used when loading dependencies of the plugins (these dependencies include the Level Zero loader and the ICD loader for opencl and level zero plugins respectively) and that list includes current directory and some other directories which are not considered safe. This patch limits the list of directories when loading the dependencies of the plugins. See: https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibraryexa for reference. --------- Co-authored-by: aelovikov-intel <[email protected]>
…11472) - Adds support for fill and memset nodes in graphs. - Supported on Level Zero only for now. - Adds E2E and unit tests for these new node types. - Minor modifications due to renaming of some UR functions. --------- Co-authored-by: Maxime France-Pillois <[email protected]> Co-authored-by: Ewan Crawford <[email protected]>
`fabs` was missing for Nvidia compilation
Co-authored-by: Kenneth Benzie (Benie) <[email protected]> Co-authored-by: ldrumm <[email protected]>
|
Closing in favour of upstream PR: intel#12366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #340
To better support mixed use cases, where for example the user records most of a graph through record and replay but only wants to update a few parameters on a small number of nodes, queries were added to get nodes from a graph to enable more mixed usage scenarios. Current options for mixed usage are limited to using
handler::depends_on()with an event from a queue recorded node inside an explicit node to create a dependency. But giving the user access to all nodes in a graph enables use ofmake_edge()and thedepends_onproperty as well. Included here is the bare mininum, but these queries could be expanded in future in response to user needs.The queries to get nodes from a graph raises some questions about subgraphs and what we should be returning in that case. Currently the implementation actually copies these nodes directly into the parent graph and there is no single
nodethat represents a subgraph, but this could cause confusion with users since the spec wording kind of implies that. Previously this wasn't an issue because that was just an implementation detail.