Skip to content

Commit

Permalink
@rjh PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rileysdev committed Oct 2, 2023
1 parent 54630ee commit 4c8ac71
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
6 changes: 3 additions & 3 deletions api/hello_world/v1/greeter_rsm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ import { v4 as uuidv4 } from "uuid";
// TODO: create a set of input messages AND output messages and |map ..|unique
// over those to ensure there are no duplicates.
import {
GreetingsRequest,
GreetRequest,
GreetResponse,
GreetingsResponse,
GreetingsRequest,
GreetingsResponse,
GreetRequest,
} from "./greeter_pb";


Expand Down
2 changes: 1 addition & 1 deletion hello-world/backend/src/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@


async def initialize(workflow: Workflow):
logging.info(f"Greeter is ready...")
logging.info(f"Greeter is ready... Try recording a greeting!")


async def main():
Expand Down
9 changes: 5 additions & 4 deletions hello-world/web/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
// Add a comment: you can choose any id because the greeter will get constructed.
import { useState } from "react";
import { FC, useState } from "react";
import css from "./App.module.css";
import { Greeter } from "./api/hello_world/v1/greeter_rsm";

// We can choose any id we want because the state will be constructed when we
// make the first writer call.
const GREETER_ID = "greeter-hello-world";

const Greeting: React.FC<{ text: string }> = ({ text }) => {
const Greeting: FC<{ text: string }> = ({ text }) => {
return <div className={css.greeting}>{text}</div>;
};

Expand All @@ -30,7 +31,7 @@ const App = () => {
{response !== undefined &&
response.greetings.length > 0 &&
response.greetings.map((greeting: string) => (
<Greeting text={greeting} />
<Greeting text={greeting} key={greeting}/>
))}
</div>
);
Expand Down

0 comments on commit 4c8ac71

Please sign in to comment.