-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge alloy-rs/ruint (ruint2), take 2 #264
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 83.31% 83.47% +0.16%
==========================================
Files 50 51 +1
Lines 5405 5483 +78
==========================================
+ Hits 4503 4577 +74
- Misses 902 906 +4
☔ View full report in Codecov by Sentry. |
generic_const_exprs = ["nightly"] | ||
|
||
# support | ||
alloy-rlp = ["dep:alloy-rlp"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the support features features now explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to be explicit, and helps in future with chaining on other features that it should enable (eg std, alloc, serde...)
Motivation
Supersedes #261.
Best reviewed on a commit-by-commit basis.
cd025db:
feature = "nightly"
: https://github.com/recmo/uint/blob/35167fbf0406c8f925608225225f91f5612e371b/build.rs#L4C8-L4C76ruint
to1.9.0
, andruint-macro
to1.1.0
2d9da6f:
--all-features
Dependabot:
Other:
Solution
PR Checklist