Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge alloy-rs/ruint (ruint2), take 2 #264

Merged
merged 7 commits into from
Jul 18, 2023
Merged

feat: merge alloy-rs/ruint (ruint2), take 2 #264

merged 7 commits into from
Jul 18, 2023

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 17, 2023

Motivation

Supersedes #261.

Best reviewed on a commit-by-commit basis.

cd025db:

2d9da6f:

  • Update test workflow to allow --all-features
  • Split lint workflow into clippy, fmt, docs
  • Replace security audits to cargo-deny

Dependabot:

Other:

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 98.07% and project coverage change: +0.16 🎉

Comparison is base (91fa294) 83.31% compared to head (79767a6) 83.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   83.31%   83.47%   +0.16%     
==========================================
  Files          50       51       +1     
  Lines        5405     5483      +78     
==========================================
+ Hits         4503     4577      +74     
- Misses        902      906       +4     
Impacted Files Coverage Δ
ruint-macro/src/lib.rs 96.42% <ø> (ø)
src/algorithms/ops.rs 100.00% <ø> (ø)
src/from.rs 62.78% <ø> (-0.24%) ⬇️
src/support/arbitrary.rs 95.65% <ø> (ø)
src/support/ark_ff.rs 78.57% <ø> (ø)
src/support/bn_rs.rs 0.00% <ø> (ø)
src/support/num_bigint.rs 94.54% <ø> (-0.20%) ⬇️
src/support/postgres.rs 37.50% <ø> (-0.42%) ⬇️
src/support/primitive_types.rs 100.00% <ø> (ø)
src/support/pyo3.rs 96.00% <ø> (ø)
... and 15 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DaniPopes DaniPopes marked this pull request as ready for review July 18, 2023 00:10
generic_const_exprs = ["nightly"]

# support
alloy-rlp = ["dep:alloy-rlp"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the support features features now explicit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to be explicit, and helps in future with chaining on other features that it should enable (eg std, alloc, serde...)

src/support/mod.rs Outdated Show resolved Hide resolved
@prestwich prestwich merged commit 5faa6ff into recmo:main Jul 18, 2023
13 checks passed
@DaniPopes DaniPopes deleted the dani/sync2 branch July 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants