Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: generalize specialized full-limb from_*_bytes impl #332

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

DaniPopes
Copy link
Contributor

Motivation

Follow up to #329

Move the specialized from_*_bytes impl to the lowest function

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (23fc40f) 80.47% compared to head (4a6074d) 80.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   80.47%   80.62%   +0.14%     
==========================================
  Files          54       54              
  Lines        6127     6131       +4     
==========================================
+ Hits         4931     4943      +12     
+ Misses       1196     1188       -8     
Files Coverage Δ
src/bytes.rs 96.18% <100.00%> (+0.06%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich prestwich merged commit 666cd31 into recmo:main Oct 15, 2023
20 checks passed
@DaniPopes DaniPopes deleted the bytes-perf branch October 15, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants