Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-allocating mul_mod #340

Closed
wants to merge 1 commit into from
Closed

Add non-allocating mul_mod #340

wants to merge 1 commit into from

Conversation

recmo
Copy link
Owner

@recmo recmo commented Oct 31, 2023

Motivation

The Vec allocation for intermediate result adds a lot of overhead to mul_mod.

Solution

Unfortunately no good solutions, but in the new variant the caller can provide
a compile time hint.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8089eab) 80.48% compared to head (9f2a4be) 80.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   80.48%   80.17%   -0.32%     
==========================================
  Files          54       54              
  Lines        6140     6153      +13     
==========================================
- Hits         4942     4933       -9     
- Misses       1198     1220      +22     
Files Coverage Δ
src/modular.rs 92.63% <0.00%> (-6.81%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniPopes
Copy link
Contributor

DaniPopes commented May 27, 2024

@prestwich this can be closed with #373

@prestwich prestwich closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants