Feature/18743 v4 depricated modules warnings AB#18743 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomMatiom
approved these changes
Feb 19, 2024
|
Updated |
tom-reinders
requested changes
Feb 19, 2024
| variable "api_type" { | ||
| type = string | ||
| description = "Type of API. Possible values are graphql, http, soap, and websocket" | ||
| default = null |
There was a problem hiding this comment.
Suggested change
| default = null | |
| default = "http" |
| @@ -41,7 +41,7 @@ resource "azurerm_api_management_api" "api" { | |||
| authorization_server_name = "${lower(replace(var.api_settings.name, " ", "-"))}-auth" | |||
| } | |||
|
|
|||
| soap_pass_through = var.soap_pass_through | |||
| api_type = var.api_type == null && var.soap_pass_through ? "soap" : var.api_type != null ? var.api_type : "http" | |||
There was a problem hiding this comment.
Suggested change
| api_type = var.api_type == null && var.soap_pass_through ? "soap" : var.api_type != null ? var.api_type : "http" | |
| api_type = var.api_type |
Because we this is going to be in the v4 release breaking changes are not a problem, please remove soap_pass_through variable
| @@ -172,6 +172,12 @@ variable "soap_pass_through" { | |||
| default = false | |||
There was a problem hiding this comment.
soap_pass_through can be removed
| @@ -41,7 +41,7 @@ resource "azurerm_api_management_api" "api" { | |||
| authorization_server_name = "${lower(replace(var.api_settings.name, " ", "-"))}-auth" | |||
| } | |||
|
|
|||
| soap_pass_through = var.soap_pass_through | |||
| api_type = (var.api_type == null && var.soap_pass_through) ? "soap" : var.api_type != null ? var.api_type : "http" | |||
There was a problem hiding this comment.
Suggested change
| api_type = (var.api_type == null && var.soap_pass_through) ? "soap" : var.api_type != null ? var.api_type : "http" | |
| api_type = var.api_type |
Because we this is going to be in the v4 release breaking changes are not a problem, please remove soap_pass_through variable
There was a problem hiding this comment.
Version ~> 2.36 of hashicorp/azuread does not support client_id please update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up for previous PR heading into develop branch but in this case it is addition into v4
Feel free to check your comments (@tom-reinders , @ArtiomMatiom ) in previous PR on this link bellow
Due to step validation failing on lack of disk space I did also introduced some small disk space cleaning based on link bellow
https://github.com/marketplace/actions/free-disk-space-ubuntu
#385