Fix nightly test errors #2045

loomlike · 2023-12-19T09:22:12Z

Description

Fix nightly test errors

Related Issues

#2041
#2035

Checklist:

I have followed the contribution guidelines and code style for this project.
I have added tests covering my contributions.
I have updated the documentation accordingly.
This PR is being made to staging branch and not to main branch.

Signed-off-by: Jun Ki Min <[email protected]>

miguelgfierro

Looks good, I have some questions

recommenders/utils/notebook_utils.py

tests/unit/examples/test_notebooks_pyspark.py

miguelgfierro · 2023-12-19T16:44:46Z

tests/unit/examples/test_notebooks_python.py

@@ -83,6 +83,7 @@ def test_cornac_deep_dive_runs(notebooks, output_notebook, kernel_name):

 @pytest.mark.notebooks
 @pytest.mark.experimental
+@pytest.mark.skip(reason="rlrmc doesn't work with any officially released pymanopt package")


this is problematic. I remember we were using a specific hash of pymanopt. @anargyri @pradnyeshjoshi do you guys remember which one?

@bamdevm @pradnyeshjoshi this notebook is failing, also we have the issue #1943 any possibility to help fix it or at least any guidance on how to solve the issue?

fyi, test_geoimc_functional at the functional test also suffers the same issue.

miguelgfierro

Looks good, I have some questions

todo.txt

Signed-off-by: Jun Ki Min <[email protected]>

loomlike · 2023-12-20T00:46:14Z

New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:

SASREC's hit@10

E             Obtained: 0.3702
E             Expected: 0.4244 ± 5.0e-02

NCF's ndcg (from test_benchmark_movielens_gpu)

E             Obtained: [0.41627350482234177]
E             Expected: 0.382793 ± 5.0e-02

BPR's ndcg (from test_benchmark_movielens_cpu)

E             Obtained: [0.44499071687886577]
E             Expected: 0.094444 ± 5.0e-02

Signed-off-by: Jun Ki Min <[email protected]>

recommenders/utils/notebook_utils.py

tests/unit/examples/test_notebooks_pyspark.py

Signed-off-by: Jun Ki Min <[email protected]>

loomlike · 2023-12-20T22:42:02Z

New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:

SASREC's hit@10
E             Obtained: 0.3702
E             Expected: 0.4244 ± 5.0e-02
NCF's ndcg (from test_benchmark_movielens_gpu)
E             Obtained: [0.41627350482234177]
E             Expected: 0.382793 ± 5.0e-02
BPR's ndcg (from test_benchmark_movielens_cpu)
E             Obtained: [0.44499071687886577]
E             Expected: 0.094444 ± 5.0e-02

fixed those issues.

miguelgfierro · 2023-12-21T11:46:05Z

this is great @loomlike, if the PR is ready, do you want to merge?

* Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]>

@wutaomsft

* Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to resolve #2018 Signed-off-by: Simon Zhao <[email protected]> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <[email protected]> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <[email protected]> * Capture importerror Signed-off-by: Simon Zhao <[email protected]> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <[email protected]> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <[email protected]> * Not triggering unit tests on Draft PR (#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <[email protected]> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Add missing kernelspec language Signed-off-by: Simon Zhao <[email protected]> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * data notebooks Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update hybrid to CF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <[email protected]> * Stop testing for deeprec Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating a jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added rst files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * license Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation dev Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Delete workflow and try via UI Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added again the workflow Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -rf Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -f Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * add git info Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token and pull before pushing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * clean Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update documentation badge Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * install all deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * try adding other sphinx extensions Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refact model rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Reviewing other rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change the way we compile the documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Using the latest JB release Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Documentation working Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <[email protected]> * Update setup.py Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <[email protected]> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <[email protected]> * Correct variable names Signed-off-by: Simon Zhao <[email protected]> * Install git in the Conda env Signed-off-by: Simon Zhao <[email protected]> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <[email protected]> * Use latest CUDA Signed-off-by: Simon Zhao <[email protected]> * Correct GPU selection Signed-off-by: Simon Zhao <[email protected]> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <[email protected]> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <[email protected]> * Install wget in Docker image Signed-off-by: Simon Zhao <[email protected]> * Update Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Jun Ki Min <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Co-authored-by: thaiminhpv <[email protected]>

@wutaomsft

* Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to resolve recommenders-team#2018 Signed-off-by: Simon Zhao <[email protected]> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <[email protected]> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <[email protected]> * Capture importerror Signed-off-by: Simon Zhao <[email protected]> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <[email protected]> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <[email protected]> * Not triggering unit tests on Draft PR (recommenders-team#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <[email protected]> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Add missing kernelspec language Signed-off-by: Simon Zhao <[email protected]> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * data notebooks Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update hybrid to CF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <[email protected]> * Stop testing for deeprec Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (recommenders-team#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (recommenders-team#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating a jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added rst files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * license Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation dev Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Delete workflow and try via UI Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added again the workflow Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -rf Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -f Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * add git info Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token and pull before pushing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * clean Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update documentation badge Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * install all deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * try adding other sphinx extensions Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refact model rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Reviewing other rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change the way we compile the documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Using the latest JB release Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Documentation working Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <[email protected]> * Update setup.py Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <[email protected]> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <[email protected]> * Correct variable names Signed-off-by: Simon Zhao <[email protected]> * Install git in the Conda env Signed-off-by: Simon Zhao <[email protected]> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <[email protected]> * Use latest CUDA Signed-off-by: Simon Zhao <[email protected]> * Correct GPU selection Signed-off-by: Simon Zhao <[email protected]> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <[email protected]> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <[email protected]> * Install wget in Docker image Signed-off-by: Simon Zhao <[email protected]> * Update Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Jun Ki Min <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Co-authored-by: thaiminhpv <[email protected]>

loomlike added 8 commits November 14, 2023 11:25

Revert tests tolerance

453fad8

Signed-off-by: Jun Ki Min <[email protected]>

Merge branch 'staging' into jumin/fix_nightly

5f79317

Signed-off-by: Jun Ki Min <[email protected]>

Fix notebook parameter parsing

bbab68c

Signed-off-by: Jun Ki Min <[email protected]>

Add notebook utils tests to test groups

e416e56

Signed-off-by: Jun Ki Min <[email protected]>

Fix notebooks

d27c17f

Signed-off-by: Jun Ki Min <[email protected]>

Fix notebook unit tests

97136d2

Signed-off-by: Jun Ki Min <[email protected]>

Update evaluation metrics name map. Handle None for exp_var

649f1b2

Signed-off-by: Jun Ki Min <[email protected]>

Fix smoke tests

9ecf302

Signed-off-by: Jun Ki Min <[email protected]>

loomlike requested review from miguelgfierro, gramhagen, anargyri, wutaomsft and SimonYansenZhao as code owners December 19, 2023 09:22

miguelgfierro reviewed Dec 19, 2023

View reviewed changes

todo.txt Outdated Show resolved Hide resolved

cleanup

06400ea

Signed-off-by: Jun Ki Min <[email protected]>

Fix functional test errors

e52e446

Signed-off-by: Jun Ki Min <[email protected]>

miguelgfierro approved these changes Dec 20, 2023

View reviewed changes

recommenders/utils/notebook_utils.py Outdated Show resolved Hide resolved

tests/unit/examples/test_notebooks_pyspark.py Show resolved Hide resolved

loomlike added 3 commits December 20, 2023 12:48

make notebook parameter update function to be private

0bd8b94

Signed-off-by: Jun Ki Min <[email protected]>

Fix benchmark notebook bug

b0bd3c0

Signed-off-by: Jun Ki Min <[email protected]>

fix remaining bugs

1a2f01c

Signed-off-by: Jun Ki Min <[email protected]>

loomlike merged commit 82ee6d3 into staging Dec 21, 2023
20 checks passed

miguelgfierro deleted the jumin/fix_nightly branch December 22, 2023 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix nightly test errors #2045

Fix nightly test errors #2045

loomlike commented Dec 19, 2023

miguelgfierro left a comment

miguelgfierro Dec 19, 2023

loomlike Dec 20, 2023

miguelgfierro left a comment

loomlike commented Dec 20, 2023 •

edited

Loading

loomlike commented Dec 20, 2023

miguelgfierro commented Dec 21, 2023

Fix nightly test errors #2045

Fix nightly test errors #2045

Conversation

loomlike commented Dec 19, 2023

Description

Related Issues

Checklist:

miguelgfierro left a comment

Choose a reason for hiding this comment

miguelgfierro Dec 19, 2023

Choose a reason for hiding this comment

loomlike Dec 20, 2023

Choose a reason for hiding this comment

miguelgfierro left a comment

Choose a reason for hiding this comment

loomlike commented Dec 20, 2023 • edited Loading

loomlike commented Dec 20, 2023

miguelgfierro commented Dec 21, 2023

loomlike commented Dec 20, 2023 •

edited

Loading