Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change candidate name and description from string to array of objects with required str, optional lang and dir fields #176

Closed
wants to merge 7 commits into from
+390 −101
Closed

Change candidate name and description from string to array of objects with required str, optional lang and dir fields #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e5ca4a
Change candidate `name` from string to array of objects (#138)
fsteeg Jul 10, 2024
42bdcbc
Extract `string_object` definition from candidate `name` (#138)
fsteeg Jul 10, 2024
f85a9c3
Use string objects in suggest responses (#138)
fsteeg Oct 9, 2024
1398197
Reuse string-object schema in data-extension-response schema (#138)
fsteeg Oct 9, 2024
1878f2b
Use string objects in property proposals, update changelog (#138)
fsteeg Oct 9, 2024
660cb23
Merge remote-tracking branch 'origin/master' into 138-candidateNameArray
fsteeg Nov 12, 2024
634ed9f
Move `string-object.json` to new `1.0-draft/schemas` (#138, #179)
fsteeg Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions 1.0-draft/examples/data-extension-property-proposal/valid/response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,68 @@
"properties": [
{
"id": "affiliation",
"name": "Affiliation"
"name": [
{
"str": "Affiliation"
}
],
"description": [
{
"str": "A corporate body associated with a person or group of persons."
}
]
},
{
"id": "geographicAreaCode",
"name": "Ländercode"
"name": [
{
"str": "Geographic Area Code",
"lang": "en"
},
{
"str": "Ländercode",
"lang": "de"
}
]
},
{
"id": "preferredName",
"name": "Bevorzugter Name"
"name": [
{
"str": "Preferred name",
"lang": "en"
},
{
"str": "Bevorzugter Name",
"lang": "de"
}
]
},
{
"id": "professionOrOccupation",
"name": "Beruf oder Beschäftigung"
"name": [
{
"str": "Profession or occupation",
"lang": "en"
},
{
"str": "Beruf oder Beschäftigung",
"lang": "de"
}
]
},
{
"id": "variantName",
"name": "Varianter Name"
"name": [
{
"str": "Variant name",
"lang": "en"
},
{
"str": "Varianter Name",
"lang": "de"
}
]
}
]
}
}
8 changes: 6 additions & 2 deletions 1.0-draft/examples/reconciliation-candidate/valid/example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"id": "1117582299",
"name": "Urbaniak, Hans-Eberhard",
"name": [
{
"str": "Urbaniak, Hans-Eberhard"
}
],
"score": 85.71888,
"features": [
{
Expand Down Expand Up @@ -41,4 +45,4 @@
]
}
]
}
}
8 changes: 6 additions & 2 deletions 1.0-draft/examples/reconciliation-result-batch/invalid/missing-id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
{
"candidates": [
{
"name": "Urbaniak, Regina",
"name": [
{
"str": "Urbaniak, Regina"
}
],
"score": 53.015232,
"match": false,
"type": [
Expand All @@ -20,4 +24,4 @@
]
}
]
}
}
14 changes: 11 additions & 3 deletions 1.0-draft/examples/reconciliation-result-batch/invalid/root-array.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
[
{
"id": "120333937",
"name": "Urbaniak, Regina",
"name": [
{
"str": "Urbaniak, Regina"
}
],
"score": 53.015232,
"match": false,
"type": [
Expand All @@ -19,7 +23,11 @@
},
{
"id": "1127147390",
"name": "Urbaniak, Jan",
"name": [
{
"str": "Urbaniak, Jan"
}
],
"score": 52.357353,
"match": false,
"type": [
Expand All @@ -35,4 +43,4 @@
}
]
]
}
}
58 changes: 49 additions & 9 deletions 1.0-draft/examples/reconciliation-result-batch/valid/example-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,18 @@
"candidates": [
{
"id": "120333937",
"name": "Urbaniak, Regina",
"description": "1969-| Diss. Fachbereich Mathematik",
"name": [
{
"str": "Urbaniak, Regina",
"lang": "de",
"dir": "auto"
}
],
"description": [
{
"str": "1969-| Diss. Fachbereich Mathematik"
}
],
"score": 53.015232,
"match": false,
"features": [
Expand Down Expand Up @@ -43,8 +53,18 @@
},
{
"id": "1127147390",
"name": "Urbaniak, Jan",
"description": "Universität Wrocław, Niederlandestudien",
"name": [
{
"str": "Urbaniak, Jan",
"lang": "de",
"dir": "auto"
}
],
"description": [
{
"str": "Universität Wrocław, Niederlandestudien"
}
],
"score": 52.357353,
"match": false,
"type": [
Expand All @@ -64,8 +84,18 @@
"candidates": [
{
"id": "123064325",
"name": "Schwanhold, Ernst",
"description": "1948-| Mitglied des Deutschen Bundestages, SPD (1993)",
"name": [
{
"str": "Schwanhold, Ernst",
"lang": "de",
"dir": "auto"
}
],
"description": [
{
"str": "1948-| Mitglied des Deutschen Bundestages, SPD (1993)"
}
],
"score": 86.43497,
"features": [
{
Expand Down Expand Up @@ -103,8 +133,18 @@
},
{
"id": "116362988X",
"name": "Schwanhold, Nadine",
"description": "Dissertation Potsdam, Universität, Mathematik-Naturwissenschaftliche Fakultät, 2017",
"name": [
{
"str": "Schwanhold, Nadine",
"lang": "de",
"dir": "auto"
}
],
"description": [
{
"str": "Dissertation Potsdam, Universität, Mathematik-Naturwissenschaftliche Fakultät, 2017"
}
],
"score": 62.04763,
"match": false,
"type": [
Expand All @@ -121,4 +161,4 @@
]
}
]
}
}
26 changes: 21 additions & 5 deletions 1.0-draft/examples/reconciliation-result-batch/valid/minimal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,41 @@
"candidates": [
{
"id": "120333937",
"name": "Urbaniak, Regina"
"name": [
{
"str": "Urbaniak, Regina"
}
]
},
{
"id": "1127147390",
"name": "Urbaniak, Jan"
"name": [
{
"str": "Urbaniak, Jan"
}
]
}
]
},
{
"candidates": [
{
"id": "123064325",
"name": "Schwanhold, Ernst"
"name": [
{
"str": "Schwanhold, Ernst"
}
]
},
{
"id": "116362988X",
"name": "Schwanhold, Nadine"
"name": [
{
"str": "Schwanhold, Nadine"
}
]
}
]
}
]
}
}
60 changes: 46 additions & 14 deletions 1.0-draft/examples/suggest-entities-response/valid/example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,62 @@
{
"result": [
{
"name": "cumulonimbus",
"description": "genus of clouds, dense towering vertical cloud associated with thunderstorms and atmospheric instability",
"name": [
{
"str": "cumulonimbus"
}
],
"description": [
{
"str": "genus of clouds, dense towering vertical cloud associated with thunderstorms and atmospheric instability"
}
],
"id": "Q182311",
"notable": [
{
"name": "cloud genera",
"id": "Q1840368"
}
{
"name": [
{
"str": "cloud genera"
}
],
"id": "Q1840368"
}
]
},
{
"name": "Cumulopuntia",
"description": "genus of plants",
"name": [
{
"str": "Cumulopuntia"
}
],
"description": [
{
"str": "genus of plants"
}
],
"id": "Q310599",
"notable": [
{
"name": "taxon",
"id": "Q16521"
}
{
"name": [
{
"str": "taxon"
}
],
"id": "Q16521"
}
]
},
{
"name": "cumulonimbus incus",
"description": "variety of cloud",
"name": [
{
"str": "cumulonimbus incus"
}
],
"description": [
{
"str": "variety of cloud"
}
],
"id": "Q1358304",
"notable": []
}
Expand Down
Loading
Loading