Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wconversion #456

Merged
merged 4 commits into from
Mar 19, 2025
Merged

Add -Wconversion #456

merged 4 commits into from
Mar 19, 2025

Conversation

MarcinKonowalczyk
Copy link
Contributor

Add warnings to prevent implicit conversions. It's a simple change and the library is already compliant.

cmake .. -DCGLM_USE_TEST=ON -DCGLM_SHARED=ON && make && make check passes

Thoughts?

@MarcinKonowalczyk
Copy link
Contributor Author

So far unrelated CI failures ("Error: retrieving gpg key timed out.")

@recp recp merged commit 4b3dcce into recp:master Mar 19, 2025
173 of 188 checks passed
@recp
Copy link
Owner

recp commented Mar 19, 2025

Hi @MarcinKonowalczyk, thanks for your contributions the PR is merged 🚀


PS: I actually like implicit conversions especially for integers 🫣 but no need to have them in cglm ( for now especially )

@MarcinKonowalczyk MarcinKonowalczyk deleted the w-conversion branch March 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants