Ensures singular attachment for 3DS container

recurly · Jan 30, 2024 · 054cd52 · 054cd52
1 parent d77cb71
commit 054cd52
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/lib/three-d-secure-action.jsx b/lib/three-d-secure-action.jsx
@@ -73,6 +73,7 @@ export default class ThreeDSecureAction extends React.PureComponent {
 
     const { actionTokenId } = props;
 
+    this._attached = false;
     this._container = React.createRef();
     this._risk = this.context.recurly.Risk();
     this._threeDSecure = this._risk.ThreeDSecure({ actionTokenId });
@@ -82,7 +83,9 @@ export default class ThreeDSecureAction extends React.PureComponent {
   }
 
   componentDidMount () {
+    if (this._attached) return;
     this._threeDSecure.attach(this._container.current);
+    this._attached = true;
   }
 
   render () {

diff --git a/test/three-d-secure-action.test.jsx b/test/three-d-secure-action.test.jsx
@@ -58,18 +58,15 @@ describe('<ThreeDSecureAction />', function () {
           />
         ));
 
-        getThreeDSecureInstanceFrom(fixture).emit('ready', );
-        expect(subject).toHaveBeenCalled();
-      });
+        const instance = getThreeDSecureInstanceFrom(fixture);
 
-      it('does nothing when no handler is provided', function () {
-        let fixture;
+        // stub strategy so that the readiness chain will not fall apart
+        instance.strategy = {
+          attach: () => {}
+        };
 
-        render(withRecurlyProvider(
-          <ThreeDSecureAction actionTokenId="test-action-token" ref={ref => fixture = ref} />
-        ));
-
-        expect(() => getThreeDSecureInstanceFrom(fixture).emit('ready', example)).not.toThrow();
+        instance.emit('ready');
+        expect(subject).toHaveBeenCalled();
       });
     });