Add StartingOn and EndingOn to sub ramp interval

recurly · Jul 18, 2023 · 55e1210 · 55e1210
1 parent a2c83d8
commit 55e1210
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Library/SubscriptionRampInterval.cs b/Library/SubscriptionRampInterval.cs
@@ -14,7 +14,7 @@ public class SubscriptionRampInterval : RecurlyEntity
         public int UnitAmountInCents { get; set; }
 
         /// <summary>Represents the date on which the ramp interval starts.</summary>
-        public DateTime? StartingOn { get; set; }
+        public DateTime StartingOn { get; set; }
 
         /// <summary>Represents the date on which the ramp interval ends.</summary>
         public DateTime? EndingOn { get; set; }

diff --git a/Test/BaseTest.cs b/Test/BaseTest.cs
@@ -249,7 +249,9 @@ public List<SubscriptionRampInterval> GetMockSubscriptionRampIntervals(int numbe
                 var rampInterval = new SubscriptionRampInterval()
                 {
                     StartingBillingCycle = (i == 0) ? 1 : i + 2,
-                    UnitAmountInCents = (numberOfRamps * 100) * (i + 1)
+                    UnitAmountInCents = (numberOfRamps * 100) * (i + 1),
+                    StartingOn = DateTime(2023,09,15),
+                    EndingOn = DateTime(2023,09,15).AddMonths(1)
                 };
                 rampIntervals.Add(rampInterval);
             }

diff --git a/Test/SubscriptionTest.cs b/Test/SubscriptionTest.cs
@@ -863,8 +863,8 @@ public void CreateSubscriptionWithCustomRamps()
 
             fromService.RampIntervals[0].StartingBillingCycle.Should().Be(1);
             fromService.RampIntervals[0].UnitAmountInCents.Should().Be(500);
-            fromService.RampIntervals[0].StartingOn.Should().Be("2024-01-12T15:38:05Z");
-            fromService.RampIntervals[0].EndingOn.Should().Be("2024-02-12T15:38:05Z");
+            fromService.RampIntervals[0].StartingOn.Should().Be("2023-09-15T00:00:00Z");
+            fromService.RampIntervals[0].EndingOn.Should().Be("2023-10-15T00:00:00Z");
             fromService.RampIntervals[1].StartingBillingCycle.Should().Be(3);
             fromService.RampIntervals[1].UnitAmountInCents.Should().Be(1000);
             fromService.RampIntervals[2].StartingBillingCycle.Should().Be(4);