Add subscription change proflex settings #833
Conversation
|
Just confirming this is for SubscriptionChange only right? They aren't able to create a new subscription with these settings? |
|
Thats correct. This feature allows a merchant to decide how they want to charge or credit a customer when a subscription is changed after the start of a billing cycle. |
smagdicatrecurly
force-pushed
the
proration_settings
branch
from
81d9660
to
8b2eff6
Compare
| var chargeInvoice = invoices.FirstOrDefault(invoice => invoice.Type == "charge"); | ||
| var creditInvoice = invoices.FirstOrDefault(invoice => invoice.Type == "credit"); | ||
|
|
||
| Assert.Equal(0, chargeInvoice.SubtotalInCents); |
There was a problem hiding this comment.
Added assertions to check proration settings applied to charges and credits here.
smagdicatrecurly
force-pushed
the
proration_settings
branch
2 times, most recently
from
db37eef
to
7df73d4
Compare
Library/ProrationSettings.cs
Outdated
|
|
||
| /// <summary> | ||
| /// Proration behavior to be applied to charges for the subscription change. | ||
| /// Can be set to FullAmount, ProratedAmount, or None. |
There was a problem hiding this comment.
Technically, you don't need to document "can be set to...".
There was a problem hiding this comment.
I thought it was helpful when hovering over that property on SubscriptionChange but if its not a common pattern to do this I can remove that.
There was a problem hiding this comment.
I see it as a pattern actually to note the possible values.
There was a problem hiding this comment.
I think that's fine for value types, such as NetTerms, but we and the consumer have access to the literal enum values.
There was a problem hiding this comment.
Ah got it. Right.
| { | ||
| xmlWriter.WriteStartElement("proration_settings"); | ||
|
|
||
| if (ProrationSettings.Charge != null) |
There was a problem hiding this comment.
Ah, thanks for adding null safety here.
| plan.Create(); | ||
| PlansToDeactivateOnDispose.Add(plan); | ||
|
|
||
| var plan2 = new Plan(GetMockPlanCode(), GetMockPlanName()) |
There was a problem hiding this comment.
Not critical, but you could make this test leaner by just changing UnitAmountInCents on the change.
There was a problem hiding this comment.
I was hoping to see BOTH credits and charges by changing the plan.
smagdicatrecurly
force-pushed
the
proration_settings
branch
from
7df73d4
to
9669d28
Compare
[Full Changelog](1.17.38...1.18.0) **Merged Pull Requests** - Add subscription change proflex settings [#833](#833) ([smagdicatrecurly](https://github.com/smagdicatrecurly))
Adds proration_settings to subscription attributes.