add revrec to purchases and adjustments #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsethbrown
force-pushed
the
add_revrec_purchases
branch
2 times, most recently
from
c3a7904 to
7d29779
Compare
faiberrec
reviewed
Mar 1, 2024
lib/recurly/invoice.rb
Outdated
| @@ -122,7 +122,7 @@ def invoice_number_with_prefix | |||
| refundable_total_in_cents | |||
| used_tax_service | |||
| business_entity_id | |||
| ) | |||
| ) + RevRec::PRODUCT_ATTRIBUTES | |||
There was a problem hiding this comment.
Why do we need the RevRec attributes in the invoice model?
I think this needs to be removed.
wsethbrown
force-pushed
the
add_revrec_purchases
branch
from
fa1b215 to
d3f5a5f
Compare
recurly-integrations
pushed a commit
that referenced
this pull request
Mar 13, 2024
[Full Changelog](2.19.10...2.19.11) **Merged Pull Requests** - add revrec to purchases and adjustments [#891](#891) ([wsethbrown](https://github.com/wsethbrown)) - add revrec to gift cards [#889](#889) ([wsethbrown](https://github.com/wsethbrown)) - add revrec to addons and items [#885](#885) ([wsethbrown](https://github.com/wsethbrown)) - Add revrec shipping methods [#883](#883) ([wsethbrown](https://github.com/wsethbrown)) - add plan setup fee revrec [#881](#881) ([wsethbrown](https://github.com/wsethbrown)) - add get business entity [#880](#880) ([wsethbrown](https://github.com/wsethbrown)) - Add pobs [#879](#879) ([wsethbrown](https://github.com/wsethbrown)) - Add RevRec features to ruby [#878](#878) ([faiberrec](https://github.com/faiberrec)) - Adding support for General Ledger Accounts [#875](#875) ([faiberrec](https://github.com/faiberrec))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add revrec to purchases and adjustments