Merge pull request #14 from recurly/DBA-1182_dereqips

DBA-1182: not require instance_ips
recurly · Jul 23, 2024 · 009ec69 · 009ec69
2 parents 231bc74 + c66b8df
commit 009ec69
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/RECURLY_CHANGELOG.md b/RECURLY_CHANGELOG.md
@@ -1,3 +1,6 @@
+## [v2.0.7_recurly] 2024-07-23
+- Remove requirement for instance_ips
+
 ## [v2.0.6_recurly] 2024-07-11
 - Migrating MySQL VM IAM
 

diff --git a/modules/mysql_vm_iam/README.md b/modules/mysql_vm_iam/README.md
@@ -3,7 +3,7 @@ This module allows you to assign IAP access to MySQL instances based on Google W
 
 Once IAP access is granted, users can connect using the command syntax below:
 
-```shell 
+```shell
 $(gcloud info --format="value(basic.python_location)") -m pip install numpy
 export CLOUDSDK_PYTHON_SITEPACKAGES=1
 
@@ -23,13 +23,13 @@ This also requires having a user on MySQL that can connect from
 |------|---------|
 | <a name="provider_google"></a> [google](#provider\_google) | n/a |
 ## Inputs
-| Name | Description | Type | Default | Required |
-|------|-------------|------|---------|:--------:|
-| <a name="input_iam_dba_email"></a> [iam\_dba\_email](#input\_iam\_dba\_email) | IAM format of the DBA Group Email in Gsuite | `string` | n/a | yes |
-| <a name="input_iap_accessor_iam"></a> [iap\_accessor\_iam](#input\_iap\_accessor\_iam) | IAM Email of the group that can access the instances via IAP | `string` | `null` | no |
-| <a name="input_instance_hostnames"></a> [instance\_hostnames](#input\_instance\_hostnames) | List of hostnames | `list(string)` | n/a | yes |
-| <a name="input_instance_ips"></a> [instance\_ips](#input\_instance\_ips) | List of IP addresses | `list(string)` | n/a | yes |
-| <a name="input_instance_zones"></a> [instance\_zones](#input\_instance\_zones) | List of zones for each hostname | `list(string)` | n/a | yes |
-| <a name="input_project_id"></a> [project\_id](#input\_project\_id) | The GCP Project ID for the instances. | `string` | n/a | yes |
-| <a name="input_secrets"></a> [secrets](#input\_secrets) | IDs of Secrets Manager secrets that contain backup user credentials | `list(string)` | `[]` | no |
-| <a name="input_service_account"></a> [service\_account](#input\_service\_account) | Service account to be used for taking snapshots | `string` | n/a | yes |
+| Name                                                                                       | Description                                                         | Type           | Default | Required |
+|--------------------------------------------------------------------------------------------|---------------------------------------------------------------------|----------------|---------|:--------:|
+| <a name="input_iam_dba_email"></a> [iam\_dba\_email](#input\_iam\_dba\_email)              | IAM format of the DBA Group Email in Gsuite                         | `string`       | n/a     |   yes    |
+| <a name="input_iap_accessor_iam"></a> [iap\_accessor\_iam](#input\_iap\_accessor\_iam)     | IAM Email of the group that can access the instances via IAP        | `string`       | `null`  |    no    |
+| <a name="input_instance_hostnames"></a> [instance\_hostnames](#input\_instance\_hostnames) | List of hostnames                                                   | `list(string)` | n/a     |   yes    |
+| <a name="input_instance_ips"></a> [instance\_ips](#input\_instance\_ips)                   | List of IP addresses                                                | `list(string)` | n/a     |    no    |
+| <a name="input_instance_zones"></a> [instance\_zones](#input\_instance\_zones)             | List of zones for each hostname                                     | `list(string)` | n/a     |   yes    |
+| <a name="input_project_id"></a> [project\_id](#input\_project\_id)                         | The GCP Project ID for the instances.                               | `string`       | n/a     |   yes    |
+| <a name="input_secrets"></a> [secrets](#input\_secrets)                                    | IDs of Secrets Manager secrets that contain backup user credentials | `list(string)` | `[]`    |    no    |
+| <a name="input_service_account"></a> [service\_account](#input\_service\_account)          | Service account to be used for taking snapshots                     | `string`       | n/a     |   yes    |
diff --git a/modules/mysql_vm_iam/variables.tf b/modules/mysql_vm_iam/variables.tf
@@ -26,6 +26,7 @@ variable "instance_hostnames" {
 variable "instance_ips" {
   type        = list(string)
   description = "List of IP addresses"
+  default     = []
 }
 
 variable "secrets" {
@@ -38,4 +39,4 @@ variable "iap_accessor_iam" {
   type        = string
   description = "IAM Email of the group that can access the instances via IAP"
   default     = null
-}
+}