Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grm: add support for converting args #74

Merged
merged 1 commit into from
Aug 6, 2024
Merged

grm: add support for converting args #74

merged 1 commit into from
Aug 6, 2024

Conversation

kou
Copy link
Member

@kou kou commented Aug 2, 2024

Before:

args = GRM.args_new
GRM.args_push(args, 'kind', 's', :const_string, 'plot3')
GRM.args_push(args, 'x', 'nD', :int, n, :voidp, x.pack('d*'))
GRM.args_push(args, 'y', 'nD', :int, n, :voidp, y.pack('d*'))
GRM.args_push(args, 'z', 'nD', :int, n, :voidp, z.pack('d*'))
GRM.plot(args)
gets
GRM.args_delete(args)

After:

GRM.plot(kind: "plot3",
         x: x,
         y: y,
         z: z)
gets

@kou kou requested a review from kojix2 August 2, 2024 05:27
@kou kou force-pushed the grm-auto-convert branch from 06a376d to 14231f5 Compare August 2, 2024 05:37
Before:

    args = GRM.args_new
    GRM.args_push(args, 'kind', 's', :const_string, 'plot3')
    GRM.args_push(args, 'x', 'nD', :int, n, :voidp, x.pack('d*'))
    GRM.args_push(args, 'y', 'nD', :int, n, :voidp, y.pack('d*'))
    GRM.args_push(args, 'z', 'nD', :int, n, :voidp, z.pack('d*'))
    GRM.plot(args)
    gets
    GRM.args_delete(args)

After:

    GRM.plot(kind: "plot3",
             x: x,
             y: y,
             z: z)
    gets
@kou kou force-pushed the grm-auto-convert branch from 14231f5 to e4c7547 Compare August 4, 2024 21:09
@kojix2 kojix2 merged commit 0cbf186 into main Aug 6, 2024
42 checks passed
@kojix2 kojix2 deleted the grm-auto-convert branch August 6, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants