Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFA RHCEPHQE-15799 #631

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

viduship
Copy link
Contributor

@viduship viduship commented Sep 1, 2024

https://issues.redhat.com/browse/RHCEPHQE-15799
due to latest pr : #626

upgrade, CEPH_BUILD: 19.1.0-59
[RH][8.0][rhel-9][openstack] Upgrade Test Run #8
https://reportportal-ocs3.apps.ocp-c1.prod.psi.redhat.com/ui/#rhcs/launches/all/3438
http://magna002.ceph.redhat.com/cephci-jenkins/results/openstack/RH/8.0/rhel-9/Upgrade/19.1.0-59/10/

  1. tier-1_rgw_upgrade_71GA_to_8x_latest : sse-s3_per_bucket_encryption_test_0.log : keyerror version_count : https://issues.redhat.com/browse/RHCEPHQE-15799

passed logs for previous test configs and the new config:
http://magna002.ceph.redhat.com/cephci-jenkins/vidushi-runs/automation/

Signed-off-by: Vidushi Mishra <[email protected]>
@viduship viduship added RGW RGW tfa-issue-fix Fix for Automation failures in TFA labels Sep 1, 2024
@viduship viduship requested a review from a team September 1, 2024 17:24
if config.test_ops["version_count"] > 0:
for vc in range(config.test_ops["version_count"]):
if config.test_ops.get("version_count", 0) > 0:
for vc in range(config.test_ops.get("version_count")):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not required but there is no harm in using get

Copy link
Contributor

@psathyan psathyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Sep 2, 2024
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: psathyan, viduship

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit d960419 into red-hat-storage:master Sep 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me RGW RGW tfa-issue-fix Fix for Automation failures in TFA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants