[rgw]fix TFA issue by adding sleep of 20 seconds after rgw restart to avoid sync status failures #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hmaheswa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… avoid sync status failures Signed-off-by: Hemanth Sai Maheswarla <[email protected]>
hmaheswa
force-pushed
the
TFA_fix_failed_to_retrieve_sync_info
branch
from
de8cf1f
to
c1723ba
Compare
hmaheswa
added
RGW
|
waiting on end to end run log to merge |
psathyan
reviewed
Oct 29, 2024
Comment on lines
+597
to
+598
| log.info("sleeping for 20 seconds") | ||
| time.sleep(20) |
There was a problem hiding this comment.
Blind sleep may work today but it could fail later or in the next build.
IMHO, we could check if the rgw service is up and running using
ceph orch ls --service_type rgw --service-name <rgw_service_name> --format json |
jq '.[0].status | select(.size !=0) | .size == .running`
There was a problem hiding this comment.
I might be wrong with the need for checking rgw based on the heading... however the code is restarting osd_process_name
It is also possible to check for that particular daemon running status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFA failures:
http://magna002.ceph.redhat.com/cephci-jenkins/results/openstack/RH/8.0/rhel-9/Weekly/19.2.0-35/rgw/10/tier-2_ssl_rgw_ms_ecpool_test/
http://magna002.ceph.redhat.com/cephci-jenkins/results/openstack/RH/8.0/rhel-9/Weekly/19.2.0-35/rgw/10/tier-2_rgw_ms-archive/
http://magna002.ceph.redhat.com/cephci-jenkins/results/openstack/RH/8.0/rhel-9/Weekly/19.2.0-35/rgw/10/tier-2_rgw_ms-archive_resharding_granular_sync/
http://magna002.ceph.redhat.com/cephci-jenkins/results/openstack/RH/8.0/rhel-9/Weekly/19.2.0-35/rgw/10/tier-2_rgw_ms_async_data_notification/
fail log before fix from my local:
http://magna002.ceph.redhat.com/cephci-jenkins/hsm/TFA_create_user_sync_issue/cephci-run-9JPIFU/
pass log after sleep of 20 seconds:
http://magna002.ceph.redhat.com/cephci-jenkins/hsm/TFA_create_user_sync_issue/cephci-run-96EMAC/
Description
Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs
click to expand checklist